[alsa-devel] sscape: general code improvements

[krzysztof.h1 at poczta.fm]

"Takashi Iwai" <tiwai at suse.de> pisze:
> At Tue, 6 Oct 2009 19:34:38 +0200,
> Krzysztof Helt wrote:
> > 
> > From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > 
> > General code and coding style improvements.
> > 
> > Add a missing argument for SET_XXX_MIDI_VOL command.
> > 
> > Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> 
> Do you really want to change oss/sscape.c that you wanted to remove?
> 

No, it is a mistake.

> 
> > ---
> > 
> > What is a standard name for switch to select internal or external midi?
> It is very easy to 
> > add such a functionality to the driver.
> 
> What do you mean exactly to switch int/ext midi?
> Usually the driver provides the interfaces for both, and let user choose.
> If they are exclusive, it's checked in the open.
> Or, if preferred, a control element can be used to choose the
> interface...
> 

The driver interface (MPU-401 UART) is only one and there is a command to switch it to the on-board synthetizer or external midi (joysitck port on the card).

Regards,
Krzysztof


---------------------------------------------------------------
Zobacz jak pracuje sie na wysokosciach.
Kliknij >>> http://link.interia.pl/f2384