[alsa-devel] sscape: general code improvements

[Takashi Iwai]

At Tue, 6 Oct 2009 19:34:38 +0200,
Krzysztof Helt wrote:
> 
> From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> 
> General code and coding style improvements.
> 
> Add a missing argument for SET_XXX_MIDI_VOL command.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>

Do you really want to change oss/sscape.c that you wanted to remove?


> ---
> 
> What is a standard name for switch to select internal or external midi? It is very easy to 
> add such a functionality to the driver.

What do you mean exactly to switch int/ext midi?
Usually the driver provides the interfaces for both, and let user choose.
If they are exclusive, it's checked in the open.
Or, if preferred, a control element can be used to choose the interface...


thanks,

Takashi