[alsa-devel] [PATCH 8/31] HDA patch_via.c: Change VT1708S & VT1702 hp mode controls

[Takashi Iwai]

At Tue, 6 Oct 2009 12:44:28 +0800,
Li Bo wrote:
> 
> Hi, Takashi
>   When independent hp switches from
>           on -> off: hp volume/switch is deactivated
>           off -> hp volume switch  is activated
>   These 2 actions are one-shot setup, so we put "need reboot" to remind user
>   that hp volume/switch update will only take effect after reboot.

First off, you don't have to "reboot" at all :)

And, the activation/deactivation can be done on the fly, so it's no
more "one-shot" action (if implemented properly).


Takashi

> 
> On Mon, Oct 5, 2009 at 11:04 PM, Takashi Iwai <tiwai at suse.de> wrote:
> > At Mon, 5 Oct 2009 22:25:15 +0800,
> > Li Bo wrote:
> >>
> >> [ALSA] HDA VIA: Change VT1708S & VT1702 hp mode controls
> >>
> >> For VT1708S and VT1702, deactivate "Headphone Playback Volume" and
> >> "Headphone Playback Mute" control if "Independent HP" mode is OFF.
> >> and rename VT1702 "Independent HP" text.
> >>
> >> Signed-off-by: Lydia Wang <lydiawang at viatech.com.cn>
> >> @@ -3342,11 +3359,13 @@
> >>
> >>  static int vt1702_auto_create_hp_ctls(struct via_spec *spec, hda_nid_t pin)
> >>  {
> >> -     int err;
> >> -
> >> +     int err, i;
> >> +     struct hda_input_mux *imux;
> >> +     static const char *texts[] = { "ON (need reboot)",
> >> +                                    "OFF (need reboot)",
> >> +                                    NULL};
> >
> > These texts look very strange...
> >
> >
> > Takashi
> >
>