[alsa-devel] [PATCH] ASoC: Use codec mutex in dapm_set_pga()

[Mark Brown]

On Thu, Oct 01, 2009 at 03:34:46PM +0300, Eero Nurkkala wrote:

> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -2071,9 +2071,9 @@ int snd_soc_dapm_stream_event(struct snd_soc_codec
> *codec,
>  			}
>  		}
>  	}
> -	mutex_unlock(&codec->mutex);
>  
>  	dapm_power_widgets(codec, event);
> +	mutex_unlock(&codec->mutex);
>  	dump_dapm(codec, __func__);
>  	return 0;
>  }
> 

> Does that make any sense?

Looks plausible, I'd need to check properly for gotchas but it's not
like we're not taking the mutex in that path already and
dapm_power_widgets() certainly ought to have the lock.  Looks like this
has been there since DAPM was originally merged.