[alsa-devel] [PATCH] ASoC: AIC23: Fixing infinite loop in resume path

[Belisko Marek]

On Fri, Nov 27, 2009 at 1:10 PM, Anuj Aggarwal <anuj.aggarwal at ti.com> wrote:
> This patch fixes two issues:
> a) Infinite loop in resume function
> b) Writes to non-existing registers in resume function
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal at ti.com>
> ---
>  sound/soc/codecs/tlv320aic23.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
> index 6b24d8b..90a0264 100644
> --- a/sound/soc/codecs/tlv320aic23.c
> +++ b/sound/soc/codecs/tlv320aic23.c
> @@ -625,11 +625,10 @@ static int tlv320aic23_resume(struct platform_device *pdev)
>  {
>        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
>        struct snd_soc_codec *codec = socdev->card->codec;
> -       int i;
>        u16 reg;
>
>        /* Sync reg_cache with the hardware */
> -       for (reg = 0; reg < ARRAY_SIZE(tlv320aic23_reg); i++) {
> +       for (reg = 0; reg < TLV320AIC23_RESET; reg++) {
ARRAY_SIZE() shouldn't be preserved?
>                u16 val = tlv320aic23_read_reg_cache(codec, reg);
>                tlv320aic23_write(codec, reg, val);
>        }
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Marek