[alsa-devel] [PATCH] ASoC: AIC23: Fixing infinite loop in resume path

Aggarwal, Anuj anuj.aggarwal at ti.com
Fri Nov 27 13:45:20 CET 2009


> > @@ -625,11 +625,10 @@ static int tlv320aic23_resume(struct
> platform_device *pdev)
> >  {
> >        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
> >        struct snd_soc_codec *codec = socdev->card->codec;
> > -       int i;
> >        u16 reg;
> >
> >        /* Sync reg_cache with the hardware */
> > -       for (reg = 0; reg < ARRAY_SIZE(tlv320aic23_reg); i++) {
> > +       for (reg = 0; reg < TLV320AIC23_RESET; reg++) {
> ARRAY_SIZE() shouldn't be preserved?
[Aggarwal, Anuj] No, since registers 0x0A - 0x0E are not present.
> >                u16 val = tlv320aic23_read_reg_cache(codec, reg);
> >                tlv320aic23_write(codec, reg, val);
> >        }
> > --


More information about the Alsa-devel mailing list