[alsa-devel] [PATCH] ALSA: ASoc: Add regulator support to CS4270 codec driver

Daniel Mack daniel at caiaq.de
Thu Nov 26 16:48:07 CET 2009


Hi Mark,

On Wed, Nov 25, 2009 at 03:38:04PM +0000, Mark Brown wrote:
> On Wed, Nov 25, 2009 at 04:20:52PM +0100, Daniel Mack wrote:
> 
> > Ok - which place would you suggest for it? Is there an ASoC callback I
> > can hook on to tell me when the whole codec isn't used anymore? I can
> > only see startup/shutdown, but I would need to my own snd_pc_substream
> > handling login in there. Other drivers do that in the probe/remove
> 
> set_bias_level().  If the device is idle then the bias will be held in
> STANDBY (or OFF in future).  If you are happy switching off the analogue
> supply separately to the others then turn that one on when in PREPARE or
> ON, and kill the others only in OFF.

I implemented that now and it seems to work fine. However, I'm unsure
about two details:

- I only added VA for now because when VD is disabled, we need to
  restore all codec information, and I can't test that here. We can
  still add that later, right?

- I'm tracking the va_reg enable state inside the driver to take anyone
  else's reference. Is that the way do do it?

Thanks,
Daniel




More information about the Alsa-devel mailing list