[alsa-devel] [patch] make some bitfields unsigned

[Takashi Iwai]

At Mon, 16 Nov 2009 11:07:17 +0200 (SAST),
Dan Carpenter wrote:
> 
> This is a clean up and doesn't change the behavior.
> 
> Bit fields should always be unsigned.  Otherwise pm_suspend_enabled will 
> be -1 when you want it to be 1.  The other bad thing is that the sparse 
> checker will complain 36 times if they aren't unsigned.
> 
> The other bitfields in that struct are unsigned already.
> 
> regards,
> dan carpenter
> 
> Signed-off-by: Dan Carpenter <error27 at gmail.com>

Thanks!  Applied now.


Takashi


> 
> --- orig/sound/pci/ice1712/ice1712.h	2009-11-14 12:09:26.000000000 +0200
> +++ devel/sound/pci/ice1712/ice1712.h	2009-11-14 12:10:01.000000000 +0200
> @@ -382,8 +382,8 @@
>  #ifdef CONFIG_PM
>  	int (*pm_suspend)(struct snd_ice1712 *);
>  	int (*pm_resume)(struct snd_ice1712 *);
> -	int pm_suspend_enabled:1;
> -	int pm_saved_is_spdif_master:1;
> +	unsigned int pm_suspend_enabled:1;
> +	unsigned int pm_saved_is_spdif_master:1;
>  	unsigned int pm_saved_spdif_ctrl;
>  	unsigned char pm_saved_spdif_cfg;
>  	unsigned int pm_saved_route;
>