[alsa-devel] [PATCH V2] ASoC - Add support for upto 16 channels on OMAP MCBSP

Jarkko Nikula jhnikula at gmail.com
Mon Nov 9 08:47:32 CET 2009


On Mon, 9 Nov 2009 09:29:01 +0200
Peter Ujfalusi <peter.ujfalusi at nokia.com> wrote:

> So this patch definitely breaks McBSP slave mode.
> In case when McBSP is slave, the SRG is not in use, and there is no point of 
> passing some bogus information in order to pass the test in 
> omap_mcbsp_dai_hw_params introduced by this patch.
> 
> I think if I set the mcbsp_data->in_freq to be:
> params_rate(params) * sample_bits * channels, and configure the mcbsp_data-
> >clk_div to be 1, might work in this case.
> 
> But after this patch the beagle board and boards which has the McBSP as slave 
> will stop working.
> 
> I'm afraid, I can not give my Ack for this :(
> 
Big thanks Peter! Me either. How on earth I didn't notice or test this
simple thing that framesize calculatation leads to zero for all other
boards than Pandora... and working Beagle audio is *must* have
feature for me...


-- 
Jarkko


More information about the Alsa-devel mailing list