[alsa-devel] [PATCH v2] ASoC: OMAP: Don't try to set unsupported OMAP_DMA_DATA_BURST_16 on OMAP1

[Janusz Krzysztofik]

Thursday 22 October 2009 12:50:40 Mark Brown napisał(a):
> On Wed, Oct 21, 2009 at 11:10:03PM +0200, Janusz Krzysztofik wrote:
> > Wednesday 21 October 2009 21:16:07 Jarkko Nikula napisał(a):
> > > I would have implemented this by "if (!cpu_class_is_omap1())
> > > {..._burst_mode}" for making sure that no new OMAP1 error is introduced
> > > in the future if there is need to add some common stuff after those
> > > burst_mode calls and probably compiler can better optimize away those
> > > burst_mode calls for OMAP1 builds.
> >
> > Yes, you're right.
> >
> > --------------------------
>
> Applied, thanks.  For ease of use with tools like git am it's nicer if
> you can include text like the above which shouldn't be in the actual
> commit log after the --- (where the diffstat ends up).

Mark, Jarkko,

Shouldn't this one go into 2.6.32 as a fix? It corrects the problem of ASoC 
not working on OMAP1 at all. I can't see it in -rc6.

Thanks,
Janusz