[alsa-devel] [PATCH] ASoC ADS117x ADC driver

[Mark Brown]

On Wed, Nov 04, 2009 at 05:49:22PM +0000, Liam Girdwood wrote:

> @@ -261,3 +265,4 @@ config SND_SOC_WM9713
>  # Amp
>  config SND_SOC_MAX9877
>  	tristate
> +

Extra whitespace.

> +#define ADS117X_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 |\
> +		SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 |\
> +		SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000 )

There's SNDRV_PCM_RATE_8000_48000

> +       ret = snd_soc_init_card(socdev);
> +       if (ret < 0) {
> +               printk(KERN_ERR "ads117x: failed to register card\n");
> +               goto card_err;

I just last night did a patch pulling the snd_soc_init_card() stuff into
the core in preparation for multi-CODEC support.  Since there's no way
you'd have known about that churn I'll take a look at updating the
driver myself.

> +static int __init ads117x_modinit(void)
> +{
> +	return snd_soc_register_dai(&ads117x_dai);
> +}
> +module_init(ads117x_modinit);
> +
> +static void __exit ads117x_exit(void)
> +{
> +	snd_soc_unregister_dai(&ads117x_dai);
> +}
> +module_exit(ads117x_exit);

This should be using standard device model stuff - I know there are some
older drivers that have not yet been updated but the goal is to reduce
that number, it's down to only 11 now.