[alsa-devel] (no subject)

[James Gardiner]

Hi, someone recently submitted changes to the patch_sigmatel.c codec source. Whatever was done is breaking my patch for the HP dv4-1222nr laptop. I also strongly suspect that other code in the stac92hd71bxx function has been affected. There is no autodetect, there is no option for modprobe that will load that codec currently, to the best of my knowledge. I've tracked the difference to snapshot 20090529. Before that, I can get it to work, there and after refuses to work properly.

Also, there was a recent change to the stac92xx_hp_check_power_status function: While the change looks good for its intended purpose of localizing board changes to the switch/case statements in the stac92hd71bxx function, the implementor reversed the if/then selector:
                if (snd_hda_codec_amp_read(codec, nid, 0, HDA_OUTPUT, 0) &
                    HDA_AMP_MUTE)
                        spec->gpio_data &= ~spec->gpio_led; /* white */
                else
                        spec->gpio_data |= spec->gpio_led; /* orange */

it should be:
                if (snd_hda_codec_amp_read(codec, nid, 0, HDA_OUTPUT, 0) &
                    HDA_AMP_MUTE)
                        spec->gpio_data |= spec->gpio_led; /* white */
                else
                        spec->gpio_data &= ~spec->gpio_led; /* orange */

The current implementation does not work-in fact sound is completely muted 100% of the time.

I'll attempt to track down the 1st problem I mentioned, but I don't know if only patch_sigmatel.c was affected, or even the source of the problem.

Thanks,
James Gardiner