[alsa-devel] [PATCH V3 2/4] AC97 driver for mpc5200

[Jon Smirl]

On Mon, May 25, 2009 at 6:26 AM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
>> +             spin_lock(&psc_dma->lock);
>> +             out_be32(&psc_dma->psc_regs->ac97_slots, psc_dma->slots);
>> +             spin_unlock(&psc_dma->lock);
>> +             break;
>
> This locking looks wrong - I'd expect it to also cover the modification
> of psc_dma->slots?  Otherwise it's hard to see what it buys you.

Grant, why are you spin locking around register access?


-- 
Jon Smirl
jonsmirl at gmail.com