[alsa-devel] [PATCH 3/4] pxa2xx-i2s: Fix inappropriate release of i2s clock

Karl Beldan karl.beldan at gmail.com
Wed May 13 22:04:20 CEST 2009


i2s_clk is 'put' for no reason in pxa2xx_i2s_shutdown.
Now we 'get' i2s_clk at probe and 'put' it at driver removal or when
probe fails.

Signed-off-by: Karl Beldan <karl.beldan at mobile-devices.fr>
---
 sound/soc/pxa/pxa2xx-i2s.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/soc/pxa/pxa2xx-i2s.c b/sound/soc/pxa/pxa2xx-i2s.c
index a461c8d..a423637 100644
--- a/sound/soc/pxa/pxa2xx-i2s.c
+++ b/sound/soc/pxa/pxa2xx-i2s.c
@@ -257,8 +257,6 @@ static void pxa2xx_i2s_shutdown(struct snd_pcm_substream
*substream,
 		pxa_i2s_wait();
 		clk_disable(clk_i2s);
 	}
-
-	clk_put(clk_i2s);
 }

 #ifdef CONFIG_PM
-- 
1.6.3.rc1.34.g0be9b

-- 
Karl


More information about the Alsa-devel mailing list