[alsa-devel] [ASoC PATCH 1/1] IMote 2 ASoC Support

[Mark Brown]

On Mon, May 04, 2009 at 02:38:00PM +0000, Jonathan Cameron wrote:

> +	/* Disable the PLL */
> +	ret = snd_soc_dai_set_pll(codec_dai, 0, 0, 0);
> +	if (ret < 0)

This seems very odd - the PLL is never enabled by your driver but you go
through and explicitly disable it every time the driver is configured.

Other than that this looks fine; you're including more headers than you
really need but that shouldn't do any harm.