[alsa-devel] [PATCH 6/9] ARM: DaVinci: ASoC: Adds McASP clock support for TI DM646X processor

[Kevin Hilman]

"Medisetty, Naresh" <naresh at ti.com> writes:

>> On Mon, Mar 16, 2009 at 08:05:25AM -0400, Naresh Medisetty wrote:
>>
>> > +     CLK("soc-audio.0", NULL, &mcasp0_clk),
>> > +     CLK("soc-audio.1", NULL, &mcasp1_clk),
>>
>> Assuming this is a shorthand for defining two platform devices for two
>> ASoC cards I'd suggest that you instead move towards registering clocks
>> for the DAIs and probing them as platform devices - take a look at how
>> the PXA AC97 driver now does this for an example.  The soc-audio device
>> will hopefully get removed at some point and you can't guarantee that
>> the user won't want to put the two DAIs into a single sound card.
>
> Yes, This is a shorthand for defining two platform devices for two
> ASoC cards.
>

Naresh,

When you move to platform device/data way of handling the clocks
(which I would prefer as well) then these clock definitions can 
use the physical clock name:


    CLK(NULL, "mcasp0" &mcasp0_clk),
    CLK(NULL, "mcasp1", &mcasp1_clk),

The platform code can do a clk_get(<physcial name>) and pass that
clk in with the platform data.

Kevin