[alsa-devel] [PATCH] ASoC: Fix long name of control for dapm_switch
Joonyoung Shim
dofmind at gmail.com
Fri Mar 6 01:28:06 CET 2009
> ok, i will resend the patch.
>
>>
>>>
>>> - switch (w->id) {
>>> - case snd_soc_dapm_mixer:
>>> - default:
>>
>> Your chanegs here appear to only flip to an if/else from a switch
>> statement? Please mention things like this in your commit logs (or
>> split them into separate patches) - it makes your changes easier to
>> review.
>
> I think that a switch statement is used unnecessarily because this part has
> only to check whether w->id is named_ctl.
> ok, i will send them into splited patches.
> Thanks.
I found your commit at for-2.6.30 branch of your repository.
Thanks for your fixes.
--
- Joonyoung Shim
More information about the Alsa-devel
mailing list