[alsa-devel] [PATCH] ASoC: TWL4030: Add EXT_MUTE gpio to reduce pop-noise effect

[Jarkko Nikula]

On Wed, 24 Jun 2009 21:25:33 -0500
Jorge Eduardo Candelaria <x0107209 at ti.com> wrote:

> According to TRM, an external FET controlled by a 1.8V output signal
> can be used to reduce the pop-noise heard when the audio amplifier is
> switched on.
> 
> The signal is controlled by a gpio pin and should be defined in the
> machine driver. However, the codec driver takes care of enabling and
> disabling this output during the headset pop attenuation sequence.
> 
> If the board does not have an EXT_MUTE, then the machine driver should
> set the value of ext_mute_gpio to -EINVAL through ramp delay setup
> data, to bypass execution of the code that manages the gpio line.
> 
Two cents side comment. Are there any reason why the mute FET can not
be driven on thus grounding the output pin always when output is not
active? I know this patch follows the TPS65950 TRM but IMO simplier and
cleanear would be consider this FET like an amplifier (with inverted
control) and define and control it only from machine driver.


-- 
Jarkko