[alsa-devel] submitting patches to ALSA

[Takashi Iwai]

At Sat, 20 Jun 2009 08:37:03 +0530,
Harsha, Priya wrote:
> 
> Thanks Takashi.
> 
> I have tested it already with aplay, papaly and firefox flash, etc,.
> 
> Regarding the firmware binary, need I send it as a part of the patch
> in the email or can I be upload it in a common location where anyone
> can access it?

Just as you like.  I don't care in which way.

> Also, I am waiting for few dependant drivers to be submitted for
> upstream before I can submit my patches otherwise it would break.

Oh, is it completely independent from the sound stuff, or could it be
a part of a big change including the sound driver?


thanks,

Takashi

> 
> Thanks,
> Harsha
> 
> 
> 
> -----Original Message-----
> From: alsa-devel-bounces at alsa-project.org [mailto:alsa-devel-bounces at alsa-project.org] On Behalf Of Takashi Iwai
> Sent: Friday, June 19, 2009 12:34 PM
> To: Harsha, Priya
> Cc: alsa-devel at alsa-project.org
> Subject: Re: [alsa-devel] submitting patches to ALSA
> 
> At Thu, 18 Jun 2009 21:33:54 +0530,
> Harsha, Priya wrote:
> > 
> > Hi,
> > 
> > This is the first time I am planning to submit patches to ALSA. Are
> > there any tips/rules I need to follow?
> 
> In general, the rule for LKML is applied here, too.
> 
> > I have followed the general guidelines like checkpatch, testing with
> > different debug configs etc.
> 
> Great.
> 
> > I have a few questions;
> > 1. Against which kernel tree should I create patches to submit to
> > ALSA devel mailing list?
> 
> Try to apply always to the latest tree, e.g. sound git tree below
> 	git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
> 
> > 2. I have to download firmware as a part of my driver. This firmware
> > file is freely distributable. How should I share the firmware binary
> > file when I send the patches? The firmware binary file would reside
> > in /lib/firmware
> 
> The firmware file would be either in alsa-firmware package or in
> linux-firmware package.  First you can put it to alsa-firmware
> package, and we can push them to the upstream linux-firmware package
> once after your driver gets merged.
> 
> > 3. Is there anything else I need to send to the mailing list in
> > addition to the patches?
> 
> A good series of patches is self-explanatory :)
> 
> > 4. Are there any test suits that I can use to test the driver?
> 
> It's a timely question.  We want to discuss this, especially per
> request from LSB.  In short answer: no test suits for the time being.
> Most people tested with aplay and speaker-test as standard test
> programs.
> 
> 
> thanks,
> 
> Takashi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>