[alsa-devel] [PATCH v4 3/4] ARM: DaVinci: ASoC: Add mcasp support for DM646x

chaithrika chaithrika at ti.com
Mon Jun 15 11:10:24 CEST 2009


On Fri, Jun 12, 2009 at 07:01:07, Denys Dmytriyenko wrote:
> Chaithrika,
> 
> On Fri, Jun 05, 2009 at 06:28:40AM -0400, Chaithrika U S wrote:
> > Adds driver support for the two instances of McASP on TI's DM646x.
> 
> In patch #3 you removed struct evm_snd_platform_data:
> 
> > -struct evm_snd_platform_data {
> > -	int tx_dma_ch;
> > -	int rx_dma_ch;
> > -};
> 
> That structure is still used in sound/soc/davinci/davinci-evm.c, until you
fix 
> it by patch #4:
> 
> > -static struct evm_snd_platform_data dm335evm_snd_data = {
> > -       .tx_dma_ch      = DAVINCI_DMA_ASP1_TX,
> > -       .rx_dma_ch      = DAVINCI_DMA_ASP1_RX,
> 
> That would break git-bisect...

Denys,

These patches have been merged. In the future, I will try to ensure that
there 
will not be a break when a patch series is submitted.

> 
> -- 
> Denys
> 


Regards, 
Chaithrika




More information about the Alsa-devel mailing list