[alsa-devel] [PATCH 4/7] Alchemy: DB1200 AC97+I2S audio support.

Manuel Lauss manuel.lauss at googlemail.com
Mon Jun 8 17:42:56 CEST 2009


Hi Mark,

On Mon, Jun 8, 2009 at 5:24 PM, Mark
Brown<broonie at opensource.wolfsonmicro.com> wrote:
>> I attached an untested patch (an addon to the patch which started this thread)
>> which does this.  Please have a look and tell me if this is what
>> suggested initially?
>
> Pretty much, though I suspect there's some confusion between the probe
> functions going on there (there's far too many of them in ASoC at the
> minute - I intend to streamline things a bit in the future but first I
> want to get the new models implemented).
>
> I'd expect it's possible to have standard platform devices declared in
> the CPU definitions for each PSC that the individual boards can just
> reference (rather than having to copy out the resources, which
> presumably are fixed for each CPU) but I'm not sure if that's idiomatic
> for MIPS code or not.  Most of ARM works that way.
>
> I'd be tempted to not bother creating the separate device for the DMA
> driver in au1xpsc_pcm_add() but that's just my personal preference.

This patch was just a quick hack, I'll clean it up and develop it further in
the coming days, then submit it to you after some testing.


> Also, you've missed a name for your audio_dev.

Nope, it's set in the following hunk depending on switch setting.


Thanks a lot for your patience!
        Manuel Lauss


More information about the Alsa-devel mailing list