[alsa-devel] [PATCH 1/4] ASoC: pxa-ssp: enhance I2S and add Left_J support

[Mark Brown]

On Mon, Jun 08, 2009 at 02:12:03PM +0200, pHilipp Zabel wrote:
> On Sat, Jun 6, 2009 at 10:12 PM, Mark
> Brown<broonie at opensource.wolfsonmicro.com> wrote:

OOI which MUA are you using?  I've noticed several people with this very
odd word wrapping the past day.

> > of in tree users it'd cause little disruption. ?A set_sample_width()
> > operation could also be added.

> set_sample_width or set_frame_width?

I'm inclined to go with sample here since it seems harder for the
machine drivers to get wrong but I've not really thought it through yet?

> I'd prefer a separate operation over a parameter to set_tdm_slot because
> in my setup I just need to force the (SSP) frame width to 16 bits.
> Enabling network mode and calling set_tdm_slot(..,1,1) wouldn't be
> necessary at all, then.

OTOH I don't really see much difference between the two cases - it's
just an extra couple of parameters on the end of the call.  That said,
it'd be much nicer if the driver were able to just do the right thing
for DSP mode unless explicitly configured, there's not the issue you
have with I2S where extra clocks would change the offset of the second
channel within a stereo frame so it's much easier.