[alsa-devel] [PATCH] ALSA: ASoC: fix NULL pointer dereference in soc_suspend()

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Jun 4 14:25:44 CEST 2009


On Wed, Jun 03, 2009 at 05:44:49PM +0200, Daniel Mack wrote:
> In case the initalization of an soc_device failed, there is no codec
> associated with it. soc_suspend() will still dereference the pointer
> and cause an Ooops when entering the sleep mode.
> 
> This happens on our board with a multi-target kernel image when booted
> on a machine without audio circuits.
> 
> This patch makes the code bail out very early in this special case.

A better fix would be to stop the device registering at all if the
initialsation fails but that's a bit more involved and in the meantime
this makes the situation better.  Probably best to wait for the real fix
until multiple cards are supported.

Thanks, I've applied this.


More information about the Alsa-devel mailing list