[alsa-devel] [Uclinux-dist-devel] [PATCH 2/5] ASoC codec: SSM2602: assign last substream to the master when shutting down

[Karl Beldan]

Mike Frysinger wrote:
> On Thu, Jun 4, 2009 at 04:17, Karl Beldan wrote:
>> Mike Frysinger wrote:
>>> On Wed, Jun 3, 2009 at 10:53, Mark Brown wrote:
>>>> On Wed, Jun 03, 2009 at 08:37:54AM -0400, Mike Frysinger wrote:
>>>>> On Wed, Jun 3, 2009 at 06:52, Mark Brown wrote:
>>>>>> However, given that this fix has missed two kernel releases due to the
>>>>>> very slow rate of responses to review comments I've applied it so users
>>>>>> get the benefit of the bug fix.
>>>>> not sure what you're referring to
>>>> This looks like a respin of a fix which was originally submitted back in
>>>> 2.6.29 era or so.  IIRC there's been two or three versions, each of
>>>> which needed fixes.
>>> it could be.  i was going by the changes that werent in 2.6.30.  i
>>> thought i looked for previous submissions, but i must have missed
>>> previous attempts.  i'm not familiar with alsa stuff, so i'm not
>>> always sure when i need to bang on Cliff to get things fixed up
>>> (changes split / better comments / etc...).
>> Anyways, this commit has been trying to fix something already fixed since the
>> first submission and if you look at its effect on the current tree you will see
>> duplicate code.
> 
> you're going to have to be a bit more specific.  i dont know alsa, so
> when i looked at the change history, i saw framework conversions.
> about the only thing that might be related is faab5a32.  is that what
> you're talking about ?

Indeed.
The commit duplicates some code, IMO this should be discussed before going further.

-- 
Karl