[alsa-devel] [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates

Karl Beldan karl.beldan at gmail.com
Wed Jun 3 14:42:02 CEST 2009


Mark Brown wrote:
> On Wed, Jun 03, 2009 at 02:11:36PM +0200, Karl Beldan wrote:
> 
>> These samples rates are supported by the codec, updating coeff_div
>> would be a better move.
> 
> It looks like the driver only supports a limited subset of the chip
> features as it is - there's also comments saying it supports asymmetric
> configurations but currently the driver only does symmetric record and
> playback setups.

True. The comment was from me.
The codec supports these rates and the driver only needs little
modification to support them (just update an array - coeff_div).
Though this commit is better than nothing, updating coeff_div seems IMO
the thing to do. This change being trivial, the commit feels like a
feature cut.

-- 
Karl


More information about the Alsa-devel mailing list