[alsa-devel] [PATCH 1/2] ALSA: snd_usb_caiaq: give better shortname
Takashi Iwai
tiwai at suse.de
Tue Jun 2 14:04:52 CEST 2009
At Tue, 2 Jun 2009 13:55:59 +0200,
Daniel Mack wrote:
>
> On Tue, Jun 02, 2009 at 01:01:35PM +0200, Takashi Iwai wrote:
> > > + /* if the id was not passed as module option, fill it with a shortened
> > > + * version of the product string which does not contain any
> > > + * whitespaces */
> > > +
> > > + if (*card->id == '\0') {
> >
> > Hm, at this place, card->id should be never an empty string so
> > this is always true.
>
> Are you sure about that? The same condition is used in
> snd_card_register() which is called _after_ the code in question from my
> driver.
Ah, no I was wrong. Actually it's set in snd_card_register()
so your method would work.
Now applied the patches.
thanks,
Takashi
More information about the Alsa-devel
mailing list