On Thu, Jul 16, 2009 at 04:00:07PM +0800, Barry Song wrote: > + /* set codec DAI slots */ > + ret = snd_soc_dai_set_tdm_slot(codec_dai, 0, 8); > + if (ret < 0) > + return ret; That mask looks wrong - it's saying not to use any slots at all. Otherwise this looks good.