[alsa-devel] [PATCH] ALSA: ASoC: Fix NULL pointer dereference in __pxa2xx_pcm_hw_free

Daniel Mack daniel at caiaq.de
Wed Jul 8 19:24:26 CEST 2009


Check for rtd->params->drcmr != NULL before accessing it.

Signed-off-by: Daniel Mack <daniel at caiaq.de>
Cc: Eric Miao <eric.miao at marvell.com>
Cc: Mark Brown <broonie at opensource.wolfsonmicro.com>
---
 sound/arm/pxa2xx-pcm-lib.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/arm/pxa2xx-pcm-lib.c b/sound/arm/pxa2xx-pcm-lib.c
index 108b643..6205f37 100644
--- a/sound/arm/pxa2xx-pcm-lib.c
+++ b/sound/arm/pxa2xx-pcm-lib.c
@@ -75,7 +75,7 @@ int __pxa2xx_pcm_hw_free(struct snd_pcm_substream *substream)
 {
 	struct pxa2xx_runtime_data *rtd = substream->runtime->private_data;
 
-	if (rtd && rtd->params)
+	if (rtd && rtd->params && rtd->params->drcmr)
 		*rtd->params->drcmr = 0;
 
 	snd_pcm_set_runtime_buffer(substream, NULL);
-- 
1.6.3.1



More information about the Alsa-devel mailing list