[alsa-devel] [PATCH] [RFC 5/13] Intel SST driver interface module

[Takashi Iwai]

At Tue, 7 Jul 2009 11:52:37 +0530,
Harsha, Priya wrote:
> 
> 
> 
> >-----Original Message-----
> >From: Takashi Iwai [mailto:tiwai at suse.de]
> >Sent: Tuesday, July 07, 2009 11:46 AM
> >To: Harsha, Priya
> >Cc: Koul, Vinod; alsa-devel at alsa-project.org; R, Dharageswari
> >Subject: Re: [alsa-devel] [PATCH] [RFC 5/13] Intel SST driver interface
> >module
> >
> >At Tue, 7 Jul 2009 11:38:54 +0530,
> >Harsha, Priya wrote:
> >>
> >> >> +void set_port_params(struct snd_sst_params *str_param,
> >> >> +				enum snd_sst_stream_ops ops)
> >> >
> >> >Is it a global function??
> >> Yes it is prototype defined in intel_sst_common.h
> >
> >Then the name is way too generic.
> Sure. I'll update them. Ill also make sure that every function name
> use is not a too generic before next submission.

Great.  A name-space is one of the things that the linux kernel codes
doesn't handle well.  It's always better to add a unique prefix to the
global names.


Takashi