[alsa-devel] [PATCH V1 10/11] ASoC: DaVinci: i2s don't limit rates

[Troy Kisky]

Mark Brown wrote:
> On Sat, Jul 04, 2009 at 07:30:00PM -0700, Troy Kisky wrote:
>> If the codec is master, we support anything
>> that the codec supports.
> 
> Hrm, tricky - the rate configuration doesn't depend on what is master so
> this could cause confusion if the codec is slave.
> 
>> -#define DAVINCI_I2S_RATES	SNDRV_PCM_RATE_8000_96000
>> +#define DAVINCI_I2S_RATES	(SNDRV_PCM_RATE_8000_96000 |\
>> +	SNDRV_PCM_RATE_5512 | SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_CONTINUOUS)
> 
> Note that the ASoC core doesn't support _KNOT or _CONTINUOUS (at least
> not properly) so the only thing you should get from this is 5512.  Is
> that really worth worrying about the master/slave problem?
> 
Ok. I'll drop this. I just needed it when I was testing all rates my codec supports.
Now that I've tested it, I don't think I'll ever use the other rates.

But even if the cpu is the clock/frame master, the sample rate generator has an 8 bit
divider field, which seems to be always 0 in the current code. And I don't see any reference
to params_rate in the davinci-i2s.c file. Has anyone tried the cpu as master???


Troy