[alsa-devel] [PATCH] [RFC 13/13] Intel SST Driver Config changes & makefile

[Takashi Iwai]

At Fri,  3 Jul 2009 11:54:58 +0530,
Vinod Koul wrote:
> 
> This patch adds the makefiles and Kconfig changes for both SST and MAD drivers
> 
> Signed-off-by: Vinod Koul <vinod.koul at intel.com>
> Signed-off-by: Harsha Priya <priya.harsha at intel.com>
> 
> 	modified:   sound/pci/Kconfig
> 	modified:   sound/pci/Makefile
> 	new file:   sound/pci/sst/Makefile
> ---
>  sound/pci/Kconfig      |   45 +++++++++++++++++++++++++++++++++++++++++++++
>  sound/pci/Makefile     |    4 +++-
>  sound/pci/sst/Makefile |    9 +++++++++
>  3 files changed, 57 insertions(+), 1 deletions(-)
>  create mode 100644 sound/pci/sst/Makefile
> 
> diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> index 748f6b7..6901393 100644
> --- a/sound/pci/Kconfig
> +++ b/sound/pci/Kconfig
> @@ -9,6 +9,51 @@ menuconfig SND_PCI
>  
>  if SND_PCI
>  
> +config SND_INTEL_SST
> +	bool "MRST SST DRIVER"
> +	depends on X86 && LNW_IPC
> +	default y
> +	help
> +	  Say Y here to include support
> +
> +config SST_OSPM_SUPPORT
> +	bool "MRST SST DRIVER SUPPORT for OSPM"
> +	depends on SND_INTEL_SST && MSTWN_POWER_MGMT
> +	default n
> +	help
> +	   Say Y here to include support in SST driver for OSPM
> +
> +config SST_IPC_NOT_INCLUDED
> +	bool "IPC NOT INCLUDED"
> +	depends on SND_INTEL_SST
> +	default y
> +	help
> +	   Say Y here to include workaround in LPE driver for removing
> +	   IPC Driver calls

Hrm, that's too cryptic.


> +config SST_DBG_PRINT
> +	bool "MRST SST DRIVER DEBUG PRINTS"
> +	depends on SND_INTEL_SST
> +	default n
> +	help
> +	   Say Y here to include debug prints for SST driver

The driver-specific debug functions should be removed as much as
possible. 
It's OK in the earlier version, but at the time to be merged to the
upstream, they should be cleaned up.

> +config SND_INTELMID
> +	bool "MRST SOUND CARD DRIVER"
> +	depends on SND_INTEL_SST && SPI_MRST
> +	default y
> +	select SND_MIXER_OSS
> +	select SND_PCM_OSS
> +	help
> +	  Say Y here to include support

More text please.


> +config MID_DBG_PRINT
> +	bool "MRST MID DRIVER DEBUG PRINTS"
> +	depends on SND_INTELMID
> +	default n
> +	help
> +	   Say Y here to include debug prints for MAD driver

Ditto.

>  config SND_AD1889
>  	tristate "Analog Devices AD1889"
>  	select SND_AC97_CODEC
> diff --git a/sound/pci/Makefile b/sound/pci/Makefile
> index ecfc609..0aea1bc 100644
> --- a/sound/pci/Makefile
> +++ b/sound/pci/Makefile
> @@ -77,4 +77,6 @@ obj-$(CONFIG_SND) += \
>  	rme9652/ \
>  	trident/ \
>  	ymfpci/ \
> -	vx222/
> +	vx222/ \
> +	sst/
> +
> diff --git a/sound/pci/sst/Makefile b/sound/pci/sst/Makefile
> new file mode 100644
> index 0000000..e87dae5
> --- /dev/null
> +++ b/sound/pci/sst/Makefile
> @@ -0,0 +1,9 @@
> +#
> +# Makefile for Intel MID Audio drivers
> +#
> +EXTRA_CFLAGS=-g

Don't add this.


Takashi