[alsa-devel] [PATCH v2 2.6.30] ASoC: remove stand-alone mode support from CS4270 codec driver

[Takashi Iwai]

At Thu, 22 Jan 2009 18:23:39 -0600,
Timur Tabi wrote:
> 
> The CS4270 supports stand-alone mode, where the codec is not connect to the
> I2C or SPI buses.  Instead, input voltages configure the codec at power-on.
> The CS4270 ASoC device driver has partial support for this mode, but the
> code was never tested, and partial support doesn't help anyone.  It also made
> the rest of the code more complicated than necessary.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
> 
> v2: Added Kconfig changes
> 
>  sound/soc/codecs/Kconfig  |    1 +
>  sound/soc/codecs/cs4270.c |   92 +++++++++++++-------------------------------
>  sound/soc/fsl/Kconfig     |    3 +-
>  3 files changed, 30 insertions(+), 66 deletions(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index cb5fcd6..136e1bc 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -65,6 +65,7 @@ config SND_SOC_AK4535
>  # Cirrus Logic CS4270 Codec
>  config SND_SOC_CS4270
>  	tristate
> +	depends on I2C

This "depends" doesn't work because CONFIG_SND_SOC_CS4270 is selected
usually by others.  The reverse-selection ignores the depends of the
target item.


Takashi