[alsa-devel] [PATCH 1/1] ALSA: ASoC: DaVinci: Fix SFFSDR init bug.

[David Brownell]

On Thursday 15 January 2009, Hugo Villeneuve wrote:
> Removed call to machine_is_sffsdr() in module init
> function because it always returns zero and causes
> GCC to optimise and remove all functions of the module.
> 
> Signed-off-by: Hugo Villeneuve <hugo at hugovil.com>

NAK.  Enable the SFF board in Kconfig, and it won't
be returning false.  If you don't enable it, you
can't possibly be running on an SFF board, and so
there's no reason to include any of these function...


> ---
>  sound/soc/davinci/davinci-sffsdr.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/davinci/davinci-sffsdr.c b/sound/soc/davinci/davinci-sffsdr.c
> index 1bbde3e..3e8e6cd 100644
> --- a/sound/soc/davinci/davinci-sffsdr.c
> +++ b/sound/soc/davinci/davinci-sffsdr.c
> @@ -115,9 +115,6 @@ static int __init sffsdr_init(void)
>  {
>  	int ret;
>  
> -	if (!machine_is_sffsdr())
> -		return -EINVAL;
> -
>  	sffsdr_snd_device = platform_device_alloc("soc-audio", 0);
>  	if (!sffsdr_snd_device) {
>  		printk(KERN_ERR "platform device allocation failed\n");
> -- 
> 1.5.4.5
> 
> 
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source at linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
> 
>