[alsa-devel] [PATCH 1/3] ASoC: Add GPIO support for jack reporting interface

[David Brownell]

On Wednesday 25 February 2009, Lopez Cruz, Misael wrote:
> +       unsigned int gpio;

Use "int" not unsigned for such might-be-a-GPIO codes ...

> +       unsigned int irq;
> +       unsigned long irqflags;
> +       irq_handler_t handler;
> +       struct work_struct work;
>  };
>  
> +#define NO_JACK_PIN_GPIO       UINT_MAX

And any negative number to flag "no GPIO";
"-EINVAL" for example.


> +               if (pins[i].gpio != NO_JACK_PIN_GPIO) {

Make that:  if (gpio_is_valid(pins[i].gpio)) ...