[alsa-devel] [PATCH] OSS: missing parentheses?
Takashi Iwai
tiwai at suse.de
Wed Feb 18 11:40:07 CET 2009
At Wed, 18 Feb 2009 10:15:00 +0100,
Roel Kluin wrote:
>
> Please review.
> --------------------------->8-------------8<------------------------------
> Add missing parentheses
>
> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
> ---
> diff --git a/sound/oss/pas2_card.c b/sound/oss/pas2_card.c
> index 25f3a22..7f377ec 100644
> --- a/sound/oss/pas2_card.c
> +++ b/sound/oss/pas2_card.c
> @@ -156,9 +156,7 @@ static int __init config_pas_hw(struct address_info *hw_config)
> * 0x80
> */ , 0xB88);
>
> - pas_write(0x80
> - | joystick?0x40:0
> - ,0xF388);
> + pas_write(0x80 | (joystick ? 0x40 : 0), 0xF388);
Yes, obviously a bug. Applied now.
Thanks!
Takashi
More information about the Alsa-devel
mailing list