[alsa-devel] Confusion about whether snd_pcm_poll_descriptors_revents()'s revents field is a single integer or an array

Jaroslav Kysela perex at perex.cz
Mon Feb 2 16:04:10 CET 2009


On Mon, 2 Feb 2009, Takashi Iwai wrote:

> ==
> >From fdd79369b24d2e9405d4ec5f1bdfc09dda127ed4 Mon Sep 17 00:00:00 2001
> From: Takashi Iwai <tiwai at suse.de>
> Date: Mon, 2 Feb 2009 15:43:48 +0100
> Subject: [PATCH] Fix handling of revents in snd_pcm_poll_descriptors_revents()
> 
> The revents parameter is ambiguously defined whether it's a pointer
> to a single event or an arary.  While the recent pcm_hw.c assumes it
> being a single event, the old multi plugin supposed it as an array.
> Similarly snd_pcm_wait_nocheck() checks the revents as an arary.

Please, remove notice about the multi plugin. It is not true.

> This patch defines the behavior of revents more strictly.  It's a
> pointer of a single event.
>
> 
> Fixed snd_pcm_wait_nocheck() to follow that.
> 
> Signed-off-by: Takashi Iwai <tiwai at suse.de>

Otherwise acked..

					Jaroslav

-----
Jaroslav Kysela <perex at perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.



More information about the Alsa-devel mailing list