[alsa-devel] 2.6.32-gitX: oops in ac97 codec registration

[Manuel Lauss]

Hi Mark,

On Thu, Dec 17, 2009 at 11:56 AM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Thu, Dec 17, 2009 at 09:40:50AM +0100, Manuel Lauss wrote:
>
>> current 2.6.32-git spits out the following oops when I load my machine
>
> Do you mean 2.6.32 or 2.6.33?

Linus' latest (so 2.6.33-rc)


>> Oops is inside snd_ac97_dev_add_pdata() call: seems ac97->dev is NULL.
>
>> I'm not entirely sure that this isn't somehow the fault of my machine driver;
>> has the procedure to register the asoc device changed since 2.6.32?
>
> The generic AC97 bodge code is broken.  Again.  I've not checked the
> ordering requirements here but reversing the order of snd_soc_new_pcms()
> and snd_ac97_bus() in ac97_soc_probe() might do the trick.

It's not that easy; seems something else is fishy.  I even get an oops with
I2S.  I'll try to find out what's going on (the same code works on
vanilla 2.6.32
though).

Manuel