[alsa-devel] [PATCH 5/5] intelhdmi - dont power off HDA link

[Takashi Iwai]

At Fri, 11 Dec 2009 12:28:37 +0800,
Wu Fengguang wrote:
> 
> For codecs without EPSS support (G45/IbexPeak), the hotplug event will
> be lost if the HDA is powered off during the time. After that the pin
> presence detection verb returns inaccurate info.
> 
> So always power-on HDA link for !EPSS codecs.
> 
> Signed-off-by: Wu Fengguang <fengguang.wu at intel.com>

I think it'd be better to add a flag to hda_bus than hda_codec like
the patch below (the change in patch_intelhdmi.c is not included).
It's a bit ugly to change the module parameter from the driver side.


thanks,

Takashi

---
diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h
index 9000d52..1d541b7 100644
--- a/sound/pci/hda/hda_codec.h
+++ b/sound/pci/hda/hda_codec.h
@@ -639,6 +639,7 @@ struct hda_bus {
 	unsigned int rirb_error:1;	/* error in codec communication */
 	unsigned int response_reset:1;	/* controller was reset */
 	unsigned int in_reset:1;	/* during reset operation */
+	unsigned int power_keep_link_on:1; /* don't power off HDA link */
 };
 
 /*
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index efcc4f7..e54420e 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2082,7 +2082,8 @@ static void azx_power_notify(struct hda_bus *bus)
 	}
 	if (power_on)
 		azx_init_chip(chip);
-	else if (chip->running && power_save_controller)
+	else if (chip->running && power_save_controller &&
+		 !bus->power_keep_link_on)
 		azx_stop_chip(chip);
 }
 #endif /* CONFIG_SND_HDA_POWER_SAVE */