[alsa-devel] [PATCH] ASoC: SDP3430: Fix TWL GPIO6 pin mux request

[Peter Ujfalusi]

On Monday 17 August 2009 21:48:27 ext Candelaria Villareal, Jorge wrote:
>   /* Set TWL4030 GPIO6 as EXTMUTE signal */
> - twl4030_i2c_write_u8(TWL4030_MODULE_INTBR, EXTMUTE(0x02),
> -       TWL4030_MODULE_INTBR);
> + twl4030_i2c_write_u8(TWL4030_MODULE_INTBR, &pin_mux,
         ^
I'm sure you wanted to have twl4030_i2c_read_u8 here.

> +      TWL4030_INTBR_PMBR1);
> + pin_mux &= ~TWL4030_GPIO6_PWM0_MUTE(0x3);
> + pin_mux |= TWL4030_GPIO6_PWM0_MUTE(0x2);

Using 0x03 and 0x02 looks better than 0x3/0x2...

> + twl4030_i2c_write_u8(TWL4030_MODULE_INTBR, pin_mux,
> +      TWL4030_INTBR_PMBR1);
>
>   ret = platform_device_add(sdp3430_snd_device);
>   if (ret)