[alsa-devel] [PATCH 2/3] ASoC: pxa-ssp.c, Automatically set TDM when needed

[Mark Brown]

On Mon, Aug 17, 2009 at 05:35:48PM +0200, Daniel Mack wrote:
> On Fri, Aug 14, 2009 at 01:17:41PM -0300, Daniel Ribeiro wrote:

> > Or when pxa is master, on pxa3xx only, with set_tdm_slot(3, 3, 2, 16).

> Again - shouldn't we care for a consistent calling convention here and
> handle the special cases in the implementation rather than feeding
> nebulous integer arguments to it, which vary depending on the clocking
> directions?

Yes, the arguments to set_tdm_slot() should have a consistent meaning
over all devices and configurations of those devices.  There will be an
inversion of the input vs. output between two connected devices but that
would be the only difference.

The key issue here is if we're looking at stereo slots or mono slots.
Stereo is probably a bit easier to work with when you're using that
(especially for I2S derived modes where the interface is fundamentally
stereo) but obviously there's the potential to run into cases where that
causes issues so mono covers our bets more.

> > This still violates the "DMYSTOP must be clear on network mode" rule,
> > but as all slots are active its not really network mode. And it seems to
> > work for you, so... ;)

> Yeah, that makes no sense at all. I think we should ignore that comment.
> It seems to be simply wrong, or we're not in network mode afterall, even
> though we selected it. I don't know.

Or the network mode is perfectly happy to support a range slot numbers
including zero.