[alsa-devel] [RFC] Break up the patch_sigmatel.c

[Takashi Iwai]

At Wed, 12 Aug 2009 23:35:45 +0300,
Maxim Levitsky wrote:
> 
> Hi folks,
> 
> I own an stac9227 and with latest kernel, it doesn't output any sound
> via front headphones. (this a is desktop)

OK, that could be my recent changes.
Could you give alsa-info.sh output, at best, on the working and
non-working states?

> I don't want to bother you with details, etc, I will fix that myself. I
> have good knowledge of the device.
> 
> However, the mess that is patch_sigmatel.c seems to be doubled. 
> its huge file, and there are loads on new codecs added.
> 
> I have a suggestion, to break it up into smaller files.
> I especially want to move all 'data' from it to header file, and sort it
> by model. 

The "data" shouldn't be in header files in general...

> Maybe move pin configs to separate file.

This could be good.

> Also I know that stac9200 is quite old, and uses many different support
> functions. I could move these in another file as well.
> 
> In other words, I want to break it up into several (5 maybe) files,
> while not touching the code itself (I so that later maybe)
> 
> Since it is quite dirty and hard work, I want to ask if you agree.

It's open source, feel free to do it.

> Btw, half of static data can be retrieved from codec by querying it
> (like dac,adc,pin node ids)

Yes.


thanks,

Takashi