[alsa-devel] suspicious code in aplay.c

[Dmitri Vorobiev]

Hello,

The following code in alsa-utils/aplay/aplay.c looks suspicious to me:

1215         if (!quiet_mode)
1216                 fprintf(stderr, _("Suspended. Trying resume. "));
fflush(stderr);

Is it really necessary to flush the stderr stream even if there was no
call to fprintf()? Perhaps these lines have to be like that:

if (!quiet_mode) {
        fprintf(stderr, _("Suspended. Trying resume. "));
        fflush(stderr);
}

Thanks,
Dmitri

P.S. I'm not subscribed to the mailing list, so please Cc: me on reply.