[alsa-devel] [PATCH][2.6.31-rc5] ARM: OMAP: McBSP: Fix ASoC on OMAP1510 by fixing API of omap_mcbsp_start/stop

[Peter Ujfalusi]

On Friday 07 August 2009 11:47:57 ext Jarkko Nikula wrote:
> On Fri, 7 Aug 2009 11:30:54 +0300
>
> Peter Ujfalusi <peter.ujfalusi at nokia.com> wrote:
> > Looks nice, but I would have done it a bit differently...
>
> ...
>
> > > -void omap_mcbsp_start(unsigned int id);
> > > -void omap_mcbsp_stop(unsigned int id);
> > > +void omap_mcbsp_start(unsigned int id, int tx, int rx);
> > > +void omap_mcbsp_stop(unsigned int id, int tx, int rx);
> >
> > void omap_mcbsp_start(unsigned int id, int dir);
> > void omap_mcbsp_stop(unsigned int id, int dir);
>
> Valid point and cleans up a bit the ALSA SoC part of the patch.
> However I didn't want to limit this generic arch/arm/plat-omap/mcbsp.c
> into audio use case only. My change still allows to start transmitter
> and receiver exactly at the same time. Might be worth if the
> generic McBSP driver is used for something else than audio.

Good point.

-- 
Péter