[alsa-devel] [PATCH 02/20] OMAP: McBSP: Wakeups utilized

[Eduardo Valentin]

On Thu, Aug 06, 2009 at 02:05:25PM +0200, ext Tony Lindgren wrote:
> * Eduardo Valentin <eduardo.valentin at nokia.com> [090731 11:08]:
> > On Thu, Jul 30, 2009 at 08:56:02PM +0200, ext Jarkko Nikula wrote:
> > > On Thu, 30 Jul 2009 15:49:25 +0300
> > > Eduardo Valentin <eduardo.valentin at nokia.com> wrote:
> > > 
> > > > --- a/arch/arm/plat-omap/mcbsp.c
> > > > +++ b/arch/arm/plat-omap/mcbsp.c
> > > > @@ -257,6 +257,23 @@ int omap_mcbsp_request(unsigned int id)
> > > >  	clk_enable(mcbsp->iclk);
> > > >  	clk_enable(mcbsp->fclk);
> > > >  
> > > > +#ifdef CONFIG_ARCH_OMAP34XX
> > > > +	/*
> > > 
> > > I'm sure there is a way to avoid all of these added ifdefs in this patch
> > > and in patches 7 and 8 as well.
> > 
> > hmmm.. these ifdef's are required because I've put the extra field (for
> > 34xx only) inside an ifdef on their declaration in mcbsp.h. We can remove it
> > there, but will leave a few extra bytes on !omap3xx binaries.
> 
> Hmm which field are you talking about? The define does not matter, and the
> u16 syscon also gets optimized out if 34xx is not selected.

dma_op_mode. see patch 0012.

> 
> Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html