[alsa-devel] [PATCH 07/20] OMAP: McBSP: Add transmit/receive threshold handler

Tony Lindgren tony at atomide.com
Thu Aug 6 14:24:25 CEST 2009


* ext-Eero.Nurkkala at nokia.com <ext-Eero.Nurkkala at nokia.com> [090806 15:22]:
> 
> >>
> >> +/********************** McBSP IRQSTATUS bit definitions ********************/
> >> +#define IRQST_XRDY           (1<<10)
> >> +#define IRQST_RRDY           (1<<3)
> >> +
> >>  /********************** McBSP WAKEUPEN bit definitions *********************/
> >>  #define XEMPTYEOFEN          0x4000
> >>  #define XRDYEN                       0x0400
> >
> > Please add spaces around << defines above.
> > 
> > Regards,
> > 
> > Tony
> 
> No spaces are used in this file at such declarations:
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=blob;f=arch/arm/plat-omap/include/mach/mcbsp.h;h=bb154ea76769509a7937c4ba472e8d04c5bf41d3;hb=HEAD
> 
> to follow the file format exactly, it'd need to be in form of 0x ?

OK, never mind then, it could be done in a clean-up patch later on.

Tony
--
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the Alsa-devel mailing list