[alsa-devel] [PATCH - amixer] listen to D-Bus for volume-up, volume-down and mute signals.

[Lukasz Stelmach]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Takashi Iwai pisze:
> At Mon, 03 Aug 2009 14:04:09 +0200,
> Lukasz Stelmach wrote:
>> Takashi Iwai pisze:
>>> At Mon,  3 Aug 2009 12:43:21 +0200,
>>> Łukasz Stelmach wrote:
>>>> The patch introduces D-Bus support in amixer. With --dbus option given amixer
>>>> works continiously (like with the --stdin) waiting for
>>>> org.freedesktop.Hal.Device.Condition with the first argument "ButtonPressed"
>>>> and the second being one of: "volume-up", "volume-down" and "mute".
[...]
>>>> Signed-off-by: Łukasz Stelmach <stlman at poczta.fm>
>>> Thanks for the patch.
>>>
>>> The approach is interesting, but I'm not sure whether we should put
>>> all into amixer in this way since we don't want extra library
>>> dependency.  (Note: amixer could be used in initrd.)
>>> I think it's better to split the code and make it as an individual
>>> daemon instead of additional options of amixer.
>> No worries ;) there is --with(out)--dbus option for configure to
>> disable all this code which is enough for initrd because most often
>> (AFAIK) initrd binaries are not the same that in the live system.
> 
> Usually same binaries are used for initrd nowadays in many distros.
> So, configure option doesn't help.

Makefile rules to build two different executable files?

> And, I really prefer this as a separate daemon, so it be as small as
> possible.

I've done some testing with all the code unused in dbus scenario
ifdefed out and it was not any smaller than full a mixer with
the patch. In fact I haven't tried to hard to understand all the
string parsing and control code, however, there doesn't seem
to be much to throw out if one wants a flexible D-Bus only tool.

>  Seeing amixer as a daemon is somewhat strange...

What about --stdin option?

- --
Było mi bardzo miło.               Czwarta pospolita klęska, [...]
>Łukasz<                 Już nie katolicka lecz złodziejska.  (c)PP
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkp3GTkACgkQNdzY8sm9K9xvdgCgh4oQzK7hbkPIbe+pLPbz89ha
ohwAnifsxiAZ1LraJzjdFPjdtR6XWL5k
=fjE8
-----END PGP SIGNATURE-----


----------------------------------------------------------------------
Zostan Dziewczyna lub Chlopakiem lata!
Wygraj skuter >> http://link.interia.pl/f22a7 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stlman.vcf
Type: text/x-vcard
Size: 176 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20090803/0e071070/attachment.bin