[alsa-devel] [PATCH] [RFC 8/13] Intel SST sound card driver

[Harsha, Priya]

Thanks. I will look into it and see if it that fixes.

Currently I am referring to the two files patch_sigmatel.c and patch_conexant.c. Are there any other files that you can point me to where I can do a compare and see?

Thanks,
Harsha.

>-----Original Message-----
>From: Mark Brown [mailto:broonie at opensource.wolfsonmicro.com]
>Sent: Monday, August 03, 2009 3:43 PM
>To: Harsha, Priya
>Cc: alsa-devel at alsa-project.org
>Subject: Re: [alsa-devel] [PATCH] [RFC 8/13] Intel SST sound card driver
>
>On Mon, Aug 03, 2009 at 12:45:08PM +0530, Harsha, Priya wrote:
>
>[Please don't top quote; it's not the normal policy for Linux lists
>since it makes the discussion harder to follow.  Please also try to
>configure your mail client to wrap lines at 80 columns for similar
>reasons.]
>
>> I tried but still finding the same issue...the probe function and the
>related functions are as follows... please let me know if you see any
>issues
>
>
>> 	ret_val = snd_intelmad_pcm(card, intelmaddata);
>> 	if (ret_val) {
>> 		sst_err("snd_intelmad_pcm failed\n");
>> 		goto free_allocs;
>> 	}
>>
>> 	ret_val = snd_intelmad_mixer(intelmaddata);
>> 	if (ret_val) {
>> 		sst_err("snd_intelmad_mixer failed\n");
>> 		goto free_allocs;
>> 	}
>>
>> 	ret_val = snd_intelmad_jack(intelmaddata);
>> 	if (ret_val) {
>> 		sst_err("snd_intelmad_jack failed\n");
>> 		goto free_allocs;
>> 	}
>
>The main difference I can see see between this and other drivers I can
>see is the ordering of the jack creation - it's normally done earlier.
>I'd suggest doing a contrast and compare with them, and also examining
>what's going on in the code.