[alsa-devel] [PATCH] ALSA: Read buffer overflow

[Takashi Iwai]

At Sun, 02 Aug 2009 13:30:45 +0200,
Roel Kluin wrote:
> 
> Check whether index is within bounds before testing the element.
> 
> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>

Applied now.  Thanks.


Takashi

> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 8c8b273..45e0ee0 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -559,7 +559,7 @@ static int alc_pin_mode_get(struct snd_kcontrol *kcontrol,
>  
>  	/* Find enumerated value for current pinctl setting */
>  	i = alc_pin_mode_min(dir);
> -	while (alc_pin_mode_values[i] != pinctl && i <= alc_pin_mode_max(dir))
> +	while (i <= alc_pin_mode_max(dir) && alc_pin_mode_values[i] != pinctl)
>  		i++;
>  	*valp = i <= alc_pin_mode_max(dir) ? i: alc_pin_mode_min(dir);
>  	return 0;
>