[alsa-devel] [PATCH v2 4/4] Rename exports in mpc5200_dma.c

[Jon Smirl]

On Mon, Apr 27, 2009 at 3:35 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Mon, Apr 27, 2009 at 12:44:47PM -0400, Jon Smirl wrote:
>> Rename the public DMA exports into the global name space so that the DMA code can be built as a module.
>
>> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_startup);
>> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_hw_free);
>> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_trigger);
>> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_shutdown);
>
> Why are you exporting these?  They should all be accessed via...

This is part of what is broken in the driver. I have later patches
that fix it but those patches are more complex.

This series is meant to be a simple mechanical transform of the driver
'as is' to make it easier to layer the successive patches on top. I
currently have twelve more patches layer on top of these four. I want
to get these code movement patches in so that we can focus on the
patches that actually fix the problems.


>
>> -struct snd_soc_platform psc_dma_pcm_soc_platform = {
>> +struct snd_soc_platform mpc5200_audio_dma_platform = {
>>       .name           = "mpc5200-psc-audio",
>>       .pcm_ops        = &psc_dma_pcm_ops,
>>       .pcm_new        = &psc_dma_pcm_new,
>>       .pcm_free       = &psc_dma_pcm_free,
>>  };
>> -
>> +EXPORT_SYMBOL_GPL(mpc5200_audio_dma_platform);
>
> ...this unless there's a reason not to do so.
>
>> -int psc_dma_startup(struct snd_pcm_substream *substream,
>> +int mpc5200_audio_dma_startup(struct snd_pcm_substream *substream,
>>                          struct snd_soc_dai *dai);
>
> These should go.
>



-- 
Jon Smirl
jonsmirl at gmail.com