[alsa-devel] Driver code with mpc5200 pointer problem.
Jon Smirl
jonsmirl at gmail.com
Mon Apr 27 16:16:16 CEST 2009
On Mon, Apr 27, 2009 at 10:05 AM, Mark Brown <broonie at sirena.org.uk> wrote:
> On Mon, Apr 27, 2009 at 10:02:47AM -0400, Jon Smirl wrote:
>
>> Is there really a problem with sending the reorg in now? There are
>> only two users of the code and we have both ack'd it.
>
> It's a fairly hefty change for -rc4. From the sounds of it you just
> need to add the constraint?
it is also broken because of the additional requirement of needing to
estimate the current position of the DMA transfer. The changes in
pcm_lib.c have made it non-functional. When I went into fix those
problems I found a couple more issues. It's ok for i2s to be broken
in this release, Grant and I both know it is broken and won't ship
anything based on it.
Here's the reorg series on linux-ppc
http://ozlabs.org/pipermail/linuxppc-dev/2009-April/071206.html
I want to do the rename of the globals that Grant suggested.
The pcm_lib.c changes may have broken other embedded drivers too. And
yes, these other drivers are probably implemented wrong and the
changes in pcm_lib.c exposed their errors. But they will be
non-functional until someone notices and fixes them.
--
Jon Smirl
jonsmirl at gmail.com
More information about the Alsa-devel
mailing list